Downgrade log message with high spam rate #1507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80degreeswest
force-pushed
the
80degreeswest/downgrade_warning_message
branch
from
b78cc4f
to
b771739
Compare
werkt
requested changes
Oct 21, 2023
80degreeswest
force-pushed
the
80degreeswest/downgrade_warning_message
branch
from
b771739
to
8d8d854
Compare
werkt
reviewed
Oct 24, 2023
| @@ -291,6 +291,12 @@ private boolean errorResponse(Throwable t) { | |||
| requestMetadata.getToolInvocationId(), | |||
| requestMetadata.getActionId(), | |||
| name)); | |||
| } else if ("write cancelled".equals(t.getMessage())) { | |||
There was a problem hiding this comment.
Prefer that we get a WriteException that specializes to a WriteCancelledException, rather than relying on correlated string messages.
There was a problem hiding this comment.
We were also getting the same error. This pr has fixed the issue for us #1526.
werkt
requested changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These log messages have a very high rate and are expected during cache expirations. Downgrade these to FINE to avoid spamming the logs.