Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tar): handle spaces in input filenames #835

Merged
merged 1 commit into from
May 8, 2024
Merged

fix(tar): handle spaces in input filenames #835

merged 1 commit into from
May 8, 2024

Conversation

alexeagle
Copy link
Collaborator

This is a partial solution to #794 that covers the most common case needing escaping. See #795 for a principled but blocked fix that requires a BSD vis executable


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: no

Test plan

  • New test cases added

@alexeagle alexeagle requested a review from thesayyn May 7, 2024 23:34
Copy link

aspect-workflows bot commented May 7, 2024

Test

3 test targets passed

Targets
//lib/tests/copy_to_directory_bin_action:test [k8-opt] 42ms
//lib/tests/jq:check_stamped [k8-opt]                  88ms
//lib/tests/yq:check_stamped [k8-opt]                  45ms

Total test execution time was 175ms. 227 tests (98.7%) were fully cached saving 39s.


Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 660ms.


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 578ms.


Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 52ms.


Test

e2e/smoke

⚠️ CircleCI build #3329 failed.

@org_golang_x_exp//maps:maps failed to build

no such package '@org_golang_x_exp//maps': no such package '@bazel_gazelle_go_repository_config//': no such
package '@bazel_gazelle_go_repository_tools//': failed to build tools: Timed out
no such package '@org_golang_x_exp//maps': no such package '@bazel_gazelle_go_repository_config//': no such
package '@bazel_gazelle_go_repository_tools//': failed to build tools: Timed out

@com_github_bmatcuk_doublestar_v4//:doublestar failed to build

no such package '@com_github_bmatcuk_doublestar_v4//': no such package
'@bazel_gazelle_go_repository_config//': no such package '@bazel_gazelle_go_repository_tools//': failed to
build tools: Timed out

💡 To reproduce the build failures, run

bazel build @org_golang_x_exp//maps:maps @com_github_bmatcuk_doublestar_v4//:doublestar

Buildifier      Format      Gazelle

This is a partial solution to #794 that covers the most common case needing escaping.
See #795 for a principled but blocked fix that requires a BSD vis executable
Copy link
Collaborator

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not likely we'll be able to port vis to starlark as starlark doesn't let us know anything about MB strings, nevertheless this is better than nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants