Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deploy script #42

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix deploy script #42

merged 1 commit into from
Oct 27, 2023

Conversation

Peddle
Copy link
Contributor

@Peddle Peddle commented Oct 26, 2023

What is this?

just fixes deploy script. no need to upgrade version

Why?

How did you test it works without regressions?

If this is a new feature what may a critical error look like?

Things to consider to not repeat mistakes we've learned from many times

  • If critical errors fire do we ping team in some obvious way (e.g., slack)?
  • Are there debug logs + a way to see these logs if we need to debug?
  • Is this documented enough a dev could work on this code without getting stuck or having to ping you?

Copy link
Member

@ErikKaum ErikKaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@Peddle Peddle merged commit 101f4ac into main Oct 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants