Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warmup deadlock in cherry #41

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fix warmup deadlock in cherry #41

merged 2 commits into from
Oct 25, 2023

Conversation

Peddle
Copy link
Contributor

@Peddle Peddle commented Oct 25, 2023

Fixes a deadlock in cherry caused by warmup not incrementing sequence number

ErikKaum
ErikKaum approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@ErikKaum ErikKaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Peddle Peddle merged commit 7fdb6aa into main Oct 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikKaum ErikKaum ErikKaum approved these changes

@nik-418 nik-418 Awaiting requested review from nik-418

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peddle @ErikKaum