Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport #1034 to 9.x #1037

Merged
merged 1 commit into from
Sep 16, 2024
Merged

backport #1034 to 9.x #1037

merged 1 commit into from
Sep 16, 2024

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 3, 2024

Backported #1034 to the 9.x branch.

JLHwung added a commit that referenced this pull request Sep 3, 2024
# Conflicts:
#	src/cache.js
#	src/index.js
@JLHwung JLHwung mentioned this pull request Sep 3, 2024
9 tasks
@JLHwung JLHwung requested review from nicolo-ribaudo and liuxingbaoyu and removed request for nicolo-ribaudo September 4, 2024 14:18
@liuxingbaoyu
Copy link
Member

Can't we just rebase 9.x?

@JLHwung
Copy link
Contributor Author

JLHwung commented Sep 4, 2024

Can't we just rebase 9.x?

I am afraid not. There have already been a few breaking changes in the current main branch:

#909
#1026
#1027

So I have to cut the 9.x branch from e449287

@nicolo-ribaudo nicolo-ribaudo merged commit a1a24ca into 9.x Sep 16, 2024
20 checks passed
nicolo-ribaudo pushed a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants