Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jtatasciore/lint #1910

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Jtatasciore/lint #1910

wants to merge 6 commits into from

Conversation

JesseTatasciore
Copy link
Member


Changes are visible to end-users: yes/no

  • Searched for relevant documentation and updated as needed: yes/no
  • Breaking change (forces users to change their own code or config): yes/no
  • Suggested release notes appear below: yes/no

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

Copy link

aspect-workflows bot commented Aug 29, 2024

Test

⚠️ Buildkite build #5752 failed.

Failed tests (1)
//npm/private/test:write_npm_translate_lock_bzlmod_0_test [k8-fastbuild]                 128ms

💡 To reproduce the test failures, run

bazel test //npm/private/test:write_npm_translate_lock_bzlmod_0_test

Test

e2e/bzlmod

Buildkite build #5752 is running...


Test

e2e/gyp_no_install_script

Buildkite build #5752 is running...


Test

e2e/js_image_oci

Buildkite build #5752 is running...


Test

e2e/npm_link_package

Buildkite build #5752 is running...


Test

e2e/npm_link_package-esm

Buildkite build #5752 is running...


Test

e2e/npm_translate_lock

Buildkite build #5752 is running...


Test

e2e/npm_translate_lock_empty

Buildkite build #5752 is running...


Test

e2e/npm_translate_lock_multi

Buildkite build #5752 is running...


Test

e2e/npm_translate_lock_partial_clone

Buildkite build #5752 is running...


Test

e2e/npm_translate_lock_replace_packages

Buildkite build #5752 is running...


Test

e2e/npm_translate_lock_subdir_patch

Buildkite build #5752 is running...


Test

e2e/npm_translate_package_lock

Buildkite build #5752 is running...


Test

e2e/npm_translate_yarn_lock

Buildkite build #5752 is running...


Test

e2e/package_json_module

Buildkite build #5752 is running...


Test

e2e/pnpm_lockfiles

Buildkite build #5752 is running...


Test

e2e/pnpm_workspace

Buildkite build #5752 is running...


Test

e2e/pnpm_workspace_rerooted

Buildkite build #5752 is running...


Test

e2e/repo_mapping

Buildkite build #5752 is running...


Test

e2e/rules_foo

Buildkite build #5752 is running...


Test

e2e/vendored_node

Buildkite build #5752 is running...


Buildifier

Buildifier managed files require formatting

--- ./BUILD.bazel	2024-08-29 01:24:52.818567397 +0000
+++ /tmp/buildifier-tmp-553689284	2024-08-29 01:25:52.538788707 +0000
@@ -138,4 +138,4 @@
     name = "prettierrc",
     srcs = [".prettierrc.cjs"],
     visibility = ["//visibility:public"],
-)
\ No newline at end of file
+)

💡 Run the following to apply the suggested formatting fixes

bazel run //:buildifier

Format

Formatting check has failed

💡 Some formatting failures can be fixed automatically by running the command below, while others may require manual fixes

bazel run //:format -- .prettierrc.cjs BUILD.bazel eslint.config.mjs foo.json

ℹ️ A patch file containing the changes has been archived as an artifact of this build


Lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants