Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feat): Parse local package.json and auto add bins #1655

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pat-trunk-io
Copy link

@pat-trunk-io pat-trunk-io commented Apr 18, 2024

Type of change

  • New feature or functionality (change which adds functionality)

Bins for external packages need to be explicitly added in the translate_lock rule, however, for package.json local to your workspace, those files can be read and the bins entry be auto added

For changes visible to end-users

  • Suggested release notes are provided below:
    package.json that are in the importer dictionary of the pnpm-lock file gets their bins auto added to linked package store

Test plan

  • New test cases added
    WIP

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@pat-trunk-io
Copy link
Author

Hi all,

I have a few local to my workspace package.json that expose bins, and it's really convenient to have them auto-added.

Currently working on adding an e2e test for this.

Copy link

aspect-workflows bot commented Apr 18, 2024

Test

Buildkite build #3197 is running...


Test

e2e/bzlmod

Buildkite build #3197 is running...


Test

e2e/gyp_no_install_script

Buildkite build #3197 is running...


Test

e2e/js_image_oci

Buildkite build #3197 is running...


Test

e2e/npm_link_package

Buildkite build #3197 is running...


Test

e2e/npm_link_package-esm

Buildkite build #3197 is running...


Test

e2e/npm_translate_lock

Buildkite build #3197 is running...


Test

e2e/npm_translate_lock_empty

Buildkite build #3197 is running...


Test

e2e/npm_translate_lock_multi

Buildkite build #3197 is running...


Test

e2e/npm_translate_lock_partial_clone

Buildkite build #3197 is running...


Test

e2e/npm_translate_lock_subdir_patch

Buildkite build #3197 is running...


Test

e2e/npm_translate_package_lock

Buildkite build #3197 is running...


Test

e2e/npm_translate_yarn_lock

Buildkite build #3197 is running...


Test

e2e/package_json_module

Buildkite build #3197 is running...


Test

e2e/pnpm_workspace

Buildkite build #3197 is running...


Test

e2e/pnpm_workspace_rerooted

Buildkite build #3197 is running...


Test

e2e/rules_foo

Buildkite build #3197 is running...


Test

e2e/vendored_node

Buildkite build #3197 is running...


Buildifier      Format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants