Skip to content

Commit

Permalink
build: upgrade to rules_js v2
Browse files Browse the repository at this point in the history
  • Loading branch information
jbedard committed Aug 15, 2024
1 parent d87e493 commit 798abd3
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module(

# Lower-bounds (minimum) versions for direct runtime dependencies
bazel_dep(name = "aspect_bazel_lib", version = "2.7.7")
bazel_dep(name = "aspect_rules_js", version = "2.0.0-rc1")
bazel_dep(name = "aspect_rules_js", version = "2.0.0")
bazel_dep(name = "bazel_skylib", version = "1.5.0")
bazel_dep(name = "platforms", version = "0.0.8")
bazel_dep(name = "rules_nodejs", version = "6.2.0")
Expand Down
2 changes: 1 addition & 1 deletion e2e/npm-links/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ local_path_override(
path = "../..",
)

bazel_dep(name = "aspect_rules_js", version = "2.0.0-rc1", dev_dependency = True)
bazel_dep(name = "aspect_rules_js", version = "2.0.0", dev_dependency = True)
bazel_dep(name = "bazel_skylib", version = "1.5.0", dev_dependency = True)

npm = use_extension("@aspect_rules_js//npm:extensions.bzl", "npm", dev_dependency = True)
Expand Down
6 changes: 3 additions & 3 deletions esbuild/dependencies.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ def rules_esbuild_dependencies():

http_archive(
name = "aspect_rules_js",
sha256 = "7085e915cdba6f2dc0ce93bef59f5d040a539b510b840456b6ac7ccc2bee7886",
strip_prefix = "rules_js-2.0.0-rc1",
url = "https://github.com/aspect-build/rules_js/releases/download/v2.0.0-rc1/rules_js-v2.0.0-rc1.tar.gz",
sha256 = "6b7e73c35b97615a09281090da3645d9f03b2a09e8caa791377ad9022c88e2e6",
strip_prefix = "rules_js-2.0.0",
url = "https://github.com/aspect-build/rules_js/releases/download/v2.0.0/rules_js-v2.0.0.tar.gz",
)

http_archive(
Expand Down
2 changes: 1 addition & 1 deletion esbuild/private/esbuild.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ def _esbuild_impl(ctx):
else:
# If we're not bundling then include all transitive files
transitive_sources = js_lib_helpers.gather_transitive_sources(
sources = output_sources_depset,
sources = output_sources,
targets = ctx.attr.srcs + ctx.attr.deps,
)
transitive_types = js_lib_helpers.gather_transitive_types(
Expand Down

0 comments on commit 798abd3

Please sign in to comment.