Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove homebrew from release artifacts and switch to monorepo versioning #743

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Sep 10, 2024

Aspect CLI OSS open-core will no longer be available at the aspect-build/aspect/aspect homebrew formula. Instead the Aspect Community Licensed Aspect CLI which includes closed source code on top of the OSS open-core will be shipped via that homebrew formula.

In the future, a from-source Homebrew formula could be created (similar to what bazelisk does) to build the Aspect CLI OSS from source and have it available at brew install aspect.

This change also switch the versioning and stamping for Aspect CLI OSS releases to use our monorepo versioning scheme <year>.<week>.<commits_in_week>-<commit_hash>. A GitHub Action on a weekly cron to add the weekly tag is added here.

Copy link

aspect-workflows bot commented Sep 10, 2024

Test

All tests were cache hits

204 tests (100.0%) were fully cached saving 7m 40s.


Buildifier      Format

@gregmagolan gregmagolan enabled auto-merge (rebase) September 10, 2024 19:49
README.md Outdated Show resolved Hide resolved
@gregmagolan gregmagolan force-pushed the remove_homebrew_releases branch 6 times, most recently from f57319f to 18012aa Compare September 28, 2024 17:02
@gregmagolan gregmagolan changed the title chore: remove homebrew from release artifacts chore: remove homebrew from release artifacts and switch to monorepo versioning Sep 28, 2024
@gregmagolan gregmagolan merged commit af217bd into main Sep 28, 2024
9 checks passed
@gregmagolan gregmagolan deleted the remove_homebrew_releases branch September 28, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants