Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate kotlin gazelle plugin parser failure #529

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

reddaly
Copy link

@reddaly reddaly commented Oct 9, 2023

Reproduce parser failure in kotlin gazelle plugin. Maybe this is a result of outdated Kotlin grammer in go-tree-sitter?.


Type of change

  • Bug fix (change which fixes an issue)

For changes visible to end-users

TODO

  • Breaking change (this change will force users to change their own code or config)
  • Relevant documentation has been updated
  • Suggested release notes are provided below:

Test plan

  • New test cases added

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jbedard jbedard marked this pull request as ready for review October 10, 2023 09:15
@jbedard jbedard marked this pull request as draft October 10, 2023 09:15
@jbedard
Copy link
Member

jbedard commented Oct 10, 2023

Can you update treesitter via go.mod to fix the validation error?

@reddaly
Copy link
Author

reddaly commented Oct 10, 2023

Can you update treesitter via go.mod to fix the validation error?

I think there is still a at least one bug upstream (for value classes). It should be fixed by fwcd/tree-sitter-kotlin#104. I can update this once that PR is merged.

@jbedard
Copy link
Member

jbedard commented Oct 10, 2023

Ok, lets wait for that 👍

@gonzojive
Copy link

Related issue: #530

@gonzojive
Copy link

I pulled in the fwcd/tree-sitter-kotlin#104 and go-tree-sitter change into #536. I'm still waiting on review of fwcd/tree-sitter-kotlin#104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants