chore(copybara): sync commits from Aspect-internal silo (#485)

Co-authored-by: Jason Bedard <[email protected]>

gazelle/js/generate.go

@@ -219,7 +219,7 @@ func (ts *typeScriptLang) addProjectRule(cfg *JsGazelleConfig, args language.Gen
 		if len(result.Errors) > 0 {
 			fmt.Printf("%s:\n", result.SourcePath)
 			for _, err := range result.Errors {
-				fmt.Printf("\t%s\n", err)
+				fmt.Printf("%s\n", err)
 			}
 			fmt.Println()
 		}

gazelle/js/parser/tests/parser.go

@@ -289,14 +289,6 @@ func RunParserTests(t *testing.T, parser parser.Parser, includeTypeOnly bool, pa
 			}
 		})
 	}
-
-	t.Run("invalid syntax"+parserPost, func(t *testing.T) {
-		_, errs := parser.ParseImports("bad-syntax.ts", "bad syntax")
-
-		if len(errs) == 0 {
-			t.Error("Invalid syntax should return errors")
-		}
-	})
 }
 
 func equal[T comparable](a, b []T) bool {

gazelle/js/parser/treesitter/parser_treesitter.go

@@ -106,9 +106,13 @@ func (p *TreeSitterParser) ParseImports(filePath, sourceCodeStr string) ([]strin
 			imports = append(imports, queryResults...)
 		}
 
-		treeErrors := treeutils.QueryErrors(sourceLangName, sourceLang, sourceCode, rootNode)
-		if treeErrors != nil {
-			errs = append(errs, treeErrors...)
+		// Parse errors. Only log them due to many false positives potentially caused by issues
+		// such as only parsing a single file at a time so type information from other files is missing.
+		if Log.IsLevelEnabled(logrus.TraceLevel) {
+			treeErrors := treeutils.QueryErrors(sourceLangName, sourceLang, sourceCode, rootNode)
+			if treeErrors != nil {
+				Log.Tracef("TreeSitter query errors: %v", treeErrors)
+			}
 		}
 	}
 

gazelle/js/tests/parse_errors/BUILD.in

@@ -0,0 +1,2 @@
+# gazelle:js_ignore_imports mystery-module
+# gazelle:js_ignore_imports unknown-library

gazelle/js/tests/parse_errors/BUILD.out

@@ -1,9 +1,13 @@
 load("@aspect_rules_ts//ts:defs.bzl", "ts_project")
 
+# gazelle:js_ignore_imports mystery-module
+# gazelle:js_ignore_imports unknown-library
+
 ts_project(
     name = "parse_errors",
     srcs = [
         "bad.ts",
+        "globals.d.ts",
         "good.ts",
     ],
 )

gazelle/js/tests/parse_errors/expectedStdout.txt

@@ -1,12 +0,0 @@
-subbuild/subbuild-bad.ts:
-	     4: bad
-        ^
-
-subdir/subdir-bad.ts:
-	     3:     bad SyntaxError on line 3()
-            ^
-
-bad.ts:
-	     2:     looks like some bad syntax here
-            ^
-

gazelle/js/tests/parse_errors/globals.d.ts

@@ -0,0 +1,13 @@
+declare module '*.module.css' {
+    const classes: { readonly [key: string]: string }
+    export default classes
+}
+
+export type { I1 } from 'mystery-module'
+export { numberFunc } from 'unknown-library'
+export interface I2 {}
+
+export interface CreatePreloadedQueryResult<D extends object, V extends I1> {
+    queryLoader: (variables: V) => Promise<Record<string, I2 | undefined>>
+    usePreloadedQueryData: () => ReturnType<typeof numberFunc>
+}