Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for web-based terminal #1309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DonaldKellett
Copy link

@DonaldKellett DonaldKellett commented Apr 17, 2024

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:

This PR implements support for the web-based terminal using the operator via the boolean field .spec.webTerminal.enabled (default is false)

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #780

How to test changes / Special notes to the reviewer:

Unit tests: [DonaldKellett/argocd-operator] make test in feature/web-terminal

With default config:

argocd-podinfo-default.mp4

With web terminal enabled:

argocd-podinfo-web-terminal-enabled.mp4

Signed-off-by: Donald Sebastian Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RBAC for web based terminal
1 participant