Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test for notification service with self-signed certs #1084

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

svghadi
Copy link
Collaborator

@svghadi svghadi commented Nov 27, 2023

What type of PR is this?
/kind test

What does this PR do / why we need it:
This PR adds a e2e test for argoproj/argo-cd#15392. The bug has been fixed in upstream argocd with argoproj/argo-cd#15394.

The source for webhook-server image used in test is added into tests/auxiliary/webhook-server. The self-signed certs are generated on linux and are valid for webhook endpoint till 2103 year.

How to test changes / Special notes to the reviewer:
Run automated kuttl test

kubectl kuttl test tests/k8s --config tests/kuttl-tests.yaml --test 1-034_validate_webhook_notifications 

spec:
containers:
- name: server
image: quay.io/svghadi/webhook-server:latest
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this image to quay.io/argoprojlabs/ similar to quay.io/argoprojlabs/argocd-notifications-e2e-smtplistener:multiarch which is used in 1-022_validate_notifications?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant