Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Haas mill variant #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gavincoelho
Copy link

Adds Haas specific mill G & M codes

Pull Request

Description

Added Haas Mill Variant
Includes Haas specific G & M codes

Issues

Reviewer Notes

Checklist

  • I have followed the guidelines in the Contributing document.
  • I have followed the Code of Conduct for this project.
  • My changes follow the coding style of this project.
  • I have run npm run test-all and it completed without errors.
  • My changes have been formatted and linted.
  • I have made any relevant changes to the documentation as needed (include CHANGELOG.md and/or README.md).
  • My changes have a descriptive commit message with a short title, including links to issues it addresses.
  • I had fun.

Adds Haas specific mill G & M codes
@mikecentola
Copy link
Member

@gavincoelho thanks for working on this. I'm going to check it out in the next day or two. I based the main "non variant" ones of Haas since that's what machines I have, but I supposed it would make sense to make the main ones as generic as possible and have Haas as a variant.

@mikecentola mikecentola self-assigned this Apr 25, 2023
@mikecentola mikecentola added the variant Variant added or updated label Apr 25, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale-pull-request variant Variant added or updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants