New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) fixed VS build #586

Merged

kylef merged 1 commit into master from tjanc/appveyor-fixes

Aug 10, 2018

Contributor

tjanc commented Aug 10, 2018

run debug builds on Appveyor
if tests fail, Appveyor fails
if tests fail, last 100 lines of drafter.log are dumped

Two bugs in tests surfaced:

test-Variant.cc: too strict assert
snowcrash tests: changed occurences of Resource resource = to const Resource& resource = due to invalid copy constructor of snowcrash::Resource; this suppresses issue Invalid copy constructor of snowcrash::Resource #585 but does not fix it


          (fix) fixed VS build

1beda7d

kylef approved these changes

View reviewed changes

kylef merged commit 3b0b060 into master

kylef deleted the tjanc/appveyor-fixes branch

August 10, 2018 10:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet