feat(core): add support for OAS3 Server object #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes APIARY-5855
kylef
requested changes
Mar 26, 2020
added 2 commits
March 26, 2020 20:00
|
@kyle I am trying to add the support for the server object to the Fury adapter, but I am missing something, can you please have a check? |
marcofriso
force-pushed
the
marco/oas3-server
branch
2 times, most recently
from
ea4487b
to
2ff7549
Compare
marcofriso
force-pushed
the
marco/oas3-server
branch
from
2ff7549
to
60a1f98
Compare
kylef
requested changes
Apr 2, 2020
packages/fury-adapter-oas3-parser/lib/parser/oas/parseServerObject.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseServerObject.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseOpenAPIObject.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseServerObject.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseOpenAPIObject-test.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseServerObject-test.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseServersArray-test.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseServersArray-test.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseServersArray-test.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseHostsObject.js
Outdated
Show resolved
Hide resolved
kylef
reviewed
Apr 3, 2020
|
|
||
| const { minim: namespace } = new Fury(); | ||
|
|
||
| describe('#parseHostsObject', () => { |
There was a problem hiding this comment.
Suggested change
| describe('#parseHostsObject', () => { | |
| describe('#parseServersArray', () => { |
To match the function we are testing.
kylef
approved these changes
Apr 6, 2020
|
@kylef As apiaryio/api-elements#62 has been merged I am merging also this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes APIARY-5855, APIARY-5856