-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-34282][docker] Merge commit 44f05828 (pre-FLINK-34282 dev-master) into dev-1.19 #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove generates/templates; these now reside in the development branches - remove testing files; these now reside in the development branches - update README.md to reflect new development/release workflow
Flink does not follow the major.minor.patch convention. - we do not have a term for x.0.0 - x.y.0 is major - x.y.z is minor
- branch creation for major releases - testing updates for minor releases
…ease.metadata file This closes apache#31
… to catch java8/11 This closes apache#46
This closes apache#48.
Deprecate command `native-k8` and add preparation for pass-through mode. This is to address the comments in the following docker-library/official-images PR. docker-library/official-images#9249 This closes apache#50
This closes apache#56
This closes apache#65
This closes apache#136.
This closes apache#138.
This closes apache#139.
… all supported versions point to the right dev-* branches 1.15 is left in there for now because we might want to release 1.15.5
- Adds item check for `.github/workflows/snapshot.yml` - Adds item updating the .github/workflows/snapshot.yml - Updated the instructions on how to create a branch (following what's already documented in the Flink release docs). - Removed step in checklist to update the aliases array in generate-stackbrew-library.sh: This became obsolete with the changes that happened in e47a802 - Moved step describing the Flink minor version branch creation and updated it slightly to match the release documentation - Removed step for updating the base version in testing/run_travis_tests.sh: This is obsolete with the changes that were done in FLINK-27488 - Removed step asking to update the latest tag in the script: This is not necessary anymore after the changes that have been committed with e47a802.
…r) into dev-1.19 dev-1.19 was initially based on master (rather than dev-master). This doesn't match the development process described in the README.md and doesn't allow the proper creation of the Docker images for 1.19. To fix this, I merged 44f0582 (pre-FLINK-34282 commit from dev-master) into dev-1.19. Merge was chosen in favor of a rebase and force-push to document the issue even though the history is kind of skrewed for dev-1.19.
hm, handling the merge commit through GitHub seems to be not working as expected. I'm gonna close this PR and move the discussion into FLINK-34282 |
This merge commit PR can be closed. I force-pushed a rebase to {{dev-master~1}} (44f05828) after a brief discussion in FLINK-34282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev-1.19
was initially based onmaster
(rather thandev-master
). This doesn't match the development process described in the README.md and doesn't allow the proper creation of the Docker images for 1.19.To fix this, I merged 44f0582 (pre-FLINK-34282 commit from dev-master) into dev-1.19. Merge was chosen in favor of a rebase and force-push to document the issue even though the history is kind of skrewed for dev-1.19.