-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44229: [Docs] Add PyArrow to JAX example to the docs #44230
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One question, jax.numpy.from_dlpack
("Returns a Array representation of a DLPack tensor") and jax.dlpack.from_dlpack
("Construct a JAX array via DLPack") seem like redundant APIs, do JAX users tend to understand which is which or could we make it clear why a user would pick one or other in this example?
Yes. JAX itself is a nice to use Python library wrapping the XLA compiler. Then it provides public interfaces inspired by famous Python libraries: there is |
Got it, thanks. |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9fa78d0. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Great addition, thanks @felipecrv! |
Rationale for this change
Explicitly mention in the docs a way that PyArrow can interop with JAX.
What changes are included in this PR?
jax.numpy
and another forjax.dlpack
Are these changes tested?
N/A