Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): explicitly declare js module type #77

Merged
merged 1 commit into from
Nov 2, 2023
Merged

chore(package): explicitly declare js module type #77

merged 1 commit into from
Nov 2, 2023

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Nov 2, 2023

Node 21.1.0 added a flag to detect module types, which will probably become default in the future. Declaring the type will cause Node to skip detection on startup/compile, reducing startup time.

Declaring the package type is also considered good practice according to https://nodejs.org/api/modules.html#enabling.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e2d3d1) 100.00% compared to head (8b4f705) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          309       309           
  Branches        72        72           
=========================================
  Hits           309       309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anonrig anonrig merged commit 6fcba3c into anonrig:main Nov 2, 2023
29 checks passed
@Fdawgs Fdawgs deleted the patch-1 branch November 2, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants