Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling improvements for Update #488

Open
wants to merge 2 commits into
base: legacy
Choose a base branch
from
Open

Error handling improvements for Update #488

wants to merge 2 commits into from

Commits on Mar 17, 2021

  1. fix(update): failing unit tests on Windows 

    Only assign versionCustom for binaries that will actually be used
Build+copy before running test-unt by itself
    @thw0rted
    thw0rted committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    8415ad5 View commit details
    Browse the repository at this point in the history

  2. fix(update): Error handling esp. for chromedriver 

    Fail when requesting chromedriver version that isn't in the manifest.
Don't swallow downloader errors.
Fail loudly if trying to download a Binary with no URL.
Exit with nonzero status on update error.
Update to latest Jasmine for improved Promise handling in specs.
    @thw0rted
    thw0rted committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    daffba4 View commit details
    Browse the repository at this point in the history