Skip to content

Commit

Permalink
Revert "fix(chromedriver): don't ignore patch version"
Browse files Browse the repository at this point in the history
This reverts commit 6a95aa4.
  • Loading branch information
Oleksandr_Travienikov committed Aug 21, 2019
1 parent 6a95aa4 commit 2f18bd5
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions lib/binaries/chrome_xml.ts
Original file line number Diff line number Diff line change
Expand Up @@ -175,12 +175,11 @@ export function getValidSemver(version: string): string {
// no-op: is this is not valid, do not throw here.
}
// This supports downloading 74.0.3729.6
// Removing the 0 after 74, to keep patch version of webdriver
try {
const newRegex = /(\d+.)\d+.(\d+.\d+)/g;
const newRegex = /(\d+.\d+.\d+).\d+/g;
const exec = newRegex.exec(version);
if (exec) {
lookUpVersion = exec[1] + exec[2];
lookUpVersion = exec[1];
}
} catch (_) {
// no-op: if this does not work, use the other regex pattern.
Expand Down

0 comments on commit 2f18bd5

Please sign in to comment.