📦 Update build-system devDependencies (major)

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@puppeteer/browsers (source)	1.9.1 -> 2.1.0
@storybook/addon-a11y (source)	7.6.17 -> 8.0.0
@storybook/addon-controls (source)	7.6.17 -> 8.0.0
@storybook/addon-viewport (source)	7.6.17 -> 8.0.0
chromedriver	119.0.1 -> 122.0.5
puppeteer-core (source)	21.11.0 -> 22.4.1

See all other Renovate PRs on the Dependency Dashboard

How to resolve breaking changes

This PR may introduce breaking changes that require manual intervention. In such cases, you will need to check out this branch, fix the cause of the breakage, and commit the fix to ensure a green CI build. To check out and update this PR, follow the steps below:

# Check out the PR branch
git checkout -b renovate/major-build-system-devdependencies main
git pull https://github.com/ampproject/amphtml.git renovate/major-build-system-devdependencies

# Directly make fixes and commit them
amp lint --fix # For lint errors in JS files
amp prettify --fix # For prettier errors in non-JS files
# Edit source code in case of new compiler warnings / errors

# Push the changes to the branch
git push [email protected]:ampproject/amphtml.git renovate/major-build-system-devdependencies:renovate/major-build-system-devdependencies

---

Release Notes

puppeteer/puppeteer (@​puppeteer/browsers)

v2.1.0

Compare Source

Big changes

• Chromium 80.0.3987.0 (r722234)
• The launcher now has an option to run Puppeteer with different browsers, starting with Firefox (#​5137). Puppeteer can now talk to a real, unpatched Firefox binary (as opposed to the old Juggler-based approach). This is a first step towards eventually deprecating the separate puppeteer-firefox package in favor of supporting Firefox directly in puppeteer itself.

Raw notes

7e7b05a - chore: mark version v2.1.0 + roll to r722234 (#​5347)
013a86c - feat(chromium): roll Chromium to r722276 (#​5289)
14b2369 - chore: mark puppeteer-firefox version v0.5.1 (#​5294)
3a49cfc - chore: move to GitHub hosting for Juggler binaries (#​5293)
c7af7de - docs(readme): update link for ndb (#​5272)
5e63254 - chore: fix typo in test name (#​5217)
80b5c44 - chore: upgrade https-proxy-agent (#​5243)
6091a34 - fix: prepare jsHandle.uploadFile for CDP Page.handleFileChooser removal (#​5196)
8b49dc6 - fix: don’t disable BlinkGenPropertyTrees anymore (#​5159)
f0bf645 - test: reduce flakiness for accessibility tests with autofocus (#​5116)
6cc98a7 - docs(troubleshooting): recommend using args for heroku (#​5197)
35d5ba5 - feat(launcher): Set default Firefox prefs (#​5149) (#​5195)
eddb23b - chore: update URLs (#​5185)
c5a72e9 - feat(launcher): add option to run Puppeteer with different browsers (#​5137)
d17708b - fix(types): publish protocol types to npm (#​5174)
fd43f9c - docs(api): fix defaultArgs link (#​5126)
5fa28b5 - docs(api): fix typo (#​5120)
561c99d - docs(api): prefer async/await over Promise#then (#​5089)
aaa904d - docs(contributing): clarify release process
304f4a7 - chore: update .npmignore
7032472 - chore: bump version to v2.0.0-post

v2.0.1

Compare Source

v2.0.0

Compare Source

Big changes

• Chromium 79.0.3942.0 (r706915)
• Puppeteer now requires Node.js v8+; Node.js v6 is no longer supported
• page.screenshot now clips elements to the viewport (#​5080)
• New APIs:
  • page.emulateTimezone(timezoneId)
  • page.emulateMediaType(type) (superseding the old page.emulateMedia(type) API)
  • page.emulateMediaFeatures(features)

API changes

• New API: page.emulateTimezone(timezoneId) (#​4949)
• New API: page.emulateMediaType(type) (#​5012)
• Deprecated API: page.emulateMedia(type) is now obsolete. Use page.emulateMediaType(type) instead. (#​5012)
• New API: page.emulateMediaFeatures(features) (#​5012)

Raw notes

aa24697 - chore: mark version v2.0.0 (#​5078)
360c1b4 - test: add page.screenshot viewport clipping test (#​5079)
7f3e372 - docs(api): improve page.waitFor docs for the options object (#​5021)
8132b39 - test: remove duplicate code from an example (#​5072)
1248a19 - feat(api): add page.emulateTimezone(timezoneId) (#​4949)
a86363f - feat(api): add page.emulateMedia{Type,Features} (#​5012)
06dbb72 - chore: use map instead of plain object (#​5068)
81d2600 - feat(chromium): roll Chromium to r705776 (#​5058)
3773229 - fix: avoid unnecessary zero-delays in input code (#​4934)
11ff374 - chore: drop Node.js v6 support (#​5045)
c0ba8f9 - docs(troubleshooting): update Alpine Chromium versions (#​4980)
2506169 - docs(contributing): mention manual docs/api updates (#​5023)
83c327a - docs(readme): correct Slack link
4c62e09 - fix(comment): fix typo in Launcher.js (#​4959)
7dbb108 - docs(api): list Chromium version for Puppeteer v1.20.0 (#​5015)
5b34028 - chore: bump https-proxy-agent to mitigate a security issue (#​5016)
dc57d03 - docs(api): clarify type method examples (#​5010)
fff2737 - doc(contributing): clarify release instructions (#​4940)
387a532 - chore: bump version to v1.20.0-post (#​4939)

storybookjs/storybook (@​storybook/addon-a11y)

v8.0.0

Compare Source

Storybook 8.0 is here

It brings major improvements to Storybook's feature set for testing and documentation, with strengthened framework support across React, Vue, Angular, web-components, Svelte, and more.

• 🩻 Built-in visual testing
• ⚛️ React Server Component support
• 🎛️ Improved controls for React and Vue projects
• ⚡️ Improved Vite architecture, Vitest testing, and Vite 5 support
• 🧪 2-4x faster Storybooks for testing
• ✨ Refreshed desktop UI
• 📲 Rebuilt mobile UX
• 🙅‍♀️ No more React requirement in non-React projects

Please checkout our Migration Guide to upgrade from earlier versions of Storybook. To see a comprehensive list of changes that went into 8.0, you can refer to the 8.0 prerelease changelogs.

giggio/node-chromedriver (chromedriver)

v122.0.5

Compare Source

v122.0.4

Compare Source

v122.0.3

Compare Source

v122.0.2

Compare Source

v122.0.1

Compare Source

v122.0.0

Compare Source

v121.0.2

Compare Source

v121.0.1

Compare Source

v121.0.0

Compare Source

v120.0.2

Compare Source

v120.0.1

Compare Source

v120.0.0

Compare Source

---

Configuration

📅 Schedule: Branch creation - "after 12am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Never, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[danielrozenberg]

Looks like there was a change in Chrome that breaks some of these tests. The breakage results from a difference here:

https://github.com/ampproject/amphtml/blob/main/extensions/amp-skimlinks/0.1/test/helpers.js#L13-L18

In Chrome 119, creating an <a> element inside the FakeWindow's Document, then setting its anchor.href to a schema-agnostic URL (e.g., anchor.href = '//a.com/';, ancho.href = 'a.com';) correctly changes the anchor.hostname field as well.

In Chrome 120, these URLs result in an empty string in anchor.hostname.

This issue only manifests itself inside the FakeWindow, it works as expected in a real window.

The one thing I noticed is that win.document.baseURI is set to http://localhost:6789/path/to/test/file.html in 119, and to about:blank in 120. I'm not sure if this is relevant, or how to continue this investigation

Help! @ychsieh @erwinmombay

[amp-owners-bot]

Hey @alanorozco! These files were changed:

build-system/tasks/storybook/package-lock.json
build-system/tasks/storybook/package.json

Hey @danielrozenberg! These files were changed:

build-system/tasks/visual-diff/browser.js
build-system/tasks/visual-diff/package-lock.json
build-system/tasks/visual-diff/package.json

[renovate]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.