Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop extra separator from symlink install destination path #536

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

cottsay
Copy link
Contributor

@cottsay cottsay commented Jun 27, 2024

The snippet for detecting the trailing / was taken from elsewhere in this file.

Before:

...
-- Install configuration: ""                  
-- Execute custom install script
-- Symlinking: /home/cottsay/rolling_ws/install/testpkg//libtestpkg.so.1.2.3
-- Symlinking: /home/cottsay/rolling_ws/install/testpkg//libtestpkg.a
-- Symlinking: /home/cottsay/rolling_ws/install/testpkg//testpkg
...

After:

...
-- Install configuration: ""
-- Execute custom install script
-- Symlinking: /home/cottsay/rolling_ws/install/testpkg/libtestpkg.so.1.2.3
-- Symlinking: /home/cottsay/rolling_ws/install/testpkg/libtestpkg.a
-- Symlinking: /home/cottsay/rolling_ws/install/testpkg/testpkg
...

@cottsay cottsay added the bug Something isn't working label Jun 27, 2024
@cottsay cottsay self-assigned this Jun 27, 2024
@cottsay cottsay force-pushed the cottsay/symlink-extra-slash branch from e9164b8 to 7e9e091 Compare June 27, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant