Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing/php7-msgpack: upgrade to 2.0.3 #5875

Closed
wants to merge 3 commits into from
Closed

testing/php7-msgpack: upgrade to 2.0.3 #5875

wants to merge 3 commits into from

Conversation

andypost
Copy link
Contributor

@andypost andypost added the A-upgrade Upgrades an abuild label Dec 21, 2018
@andypost
Copy link
Contributor Author

@fabiorphp this one also looks could go to community but I can't make tests to pass

@andypost
Copy link
Contributor Author 

FAILED TEST SUMMARY
---------------------------------------------------------------------
broken random data test [tests/040.phpt]
broken random data test : MessagePack class [tests/040b.phpt]
broken random data test : MessagePackUnpacker::feed [tests/040c.phpt]
broken random data test : MessagePackUnpacker::execute [tests/040d.phpt]

@faabiosr
Copy link
Contributor

@andypost I cloned the repo and ran the tests, but the same test problem occurs.
Unfortunately I don't know how we can fix.

@andypost
Copy link
Contributor Author

I think we should rm this tests as they fail everywhere with a reference to msgpack/msgpack-php#123

@andypost andypost force-pushed the php-msgpack branch 3 times, most recently from 9c6df85 to ce61651 Compare December 21, 2018 21:29
@andypost
Copy link
Contributor Author

Now it looks ready with patch from msgpack/msgpack-php#129

@andypost
Copy link
Contributor Author

Commited as f5227d7 8e9e111 b30acdf

@andypost andypost closed this Dec 22, 2018
@andypost andypost deleted the php-msgpack branch December 22, 2018 20:47
@andypost andypost added the C-php label Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-upgrade Upgrades an abuild C-php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andypost @faabiosr