Use GOV.UK Frontend v5 on management pages and tests #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
changed the base branch from
main
to
frontend-v5-compatibility-colin
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin
branch
from
6f55f04
to
65a2e3e
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
from
f2b5762
to
4e782dc
Compare
colinrotherham
commented
Sep 1, 2023
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin
branch
from
65a2e3e
to
c602cf6
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
from
4e782dc
to
e5d6c76
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin
branch
9 times, most recently
from
18fc10b
to
e12f909
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
from
e5d6c76
to
79c7701
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin
branch
from
e12f909
to
3ec7f0f
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
from
79c7701
to
f2fa86a
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin
branch
from
3ec7f0f
to
88a76ec
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
from
f2fa86a
to
56fc65d
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin
branch
from
7291342
to
79bbbe4
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
2 times, most recently
from
4ed5548
to
32c38b7
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin
branch
from
79bbbe4
to
ed36da2
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
from
32c38b7
to
aef666e
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin
branch
from
ed36da2
to
4a40024
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
from
aef666e
to
517c9ed
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
from
517c9ed
to
5495022
Compare
colinrotherham
force-pushed
the
frontend-v5-deprecated
branch
from
bbf1687
to
d598993
Compare
colinrotherham
changed the title
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
3 times, most recently
from
2905408
to
ae1af80
Compare
colinrotherham
changed the title
4 tasks
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
2 times, most recently
from
0ca11e4
to
02c7bff
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
from
02c7bff
to
97b777c
Compare
|
Updated with GOV.UK Frontend |
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
from
97b777c
to
a4be636
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
from
a4be636
to
6728198
Compare
colinrotherham
force-pushed
the
frontend-v5-compatibility-colin-preview
branch
from
dd37d5d
to
e4ece89
Compare
colinrotherham
commented
Jan 11, 2024
|
|
||
| const fontUrl = '/plugin-assets/govuk-frontend/govuk/assets/fonts/bold-b542beb274-v2.woff2' | ||
| const fontUrl = '/manage-prototype/dependencies/govuk-frontend/dist/govuk/assets/fonts/bold-b542beb274-v2.woff2' |
There was a problem hiding this comment.
Since plugins can use a different GOV.UK Frontend version, let's test the internal version
colinrotherham
commented
Jan 11, 2024
| cy.get('.govuk-header__logotype-text') | ||
| cy.get('.govuk-header__logotype') |
There was a problem hiding this comment.
I've changed the logo to use the parent .govuk-header__logotype
This way they'll work with both v4 and v5 should we need to switch
colinrotherham
changed the title
colinrotherham
changed the title
domoscargin
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to use GOV.UK Frontend v5 on management pages including the error server
Plugins can freely use GOV.UK Frontend v5 already but internal pages still use v4 and fail some tests
Test fixes
This PR also unblocks status checks on
mainwhere we know some tests install the latestgovuk-frontendplugin. Current CSS selectors for the logo were incompatible between v4 and v5 so have been fixed.govuk-header__logotype-text→.govuk-header__logotype