feat(protocol): payload module #89
Conversation
DoTheBestToGetTheBest
requested review from
mattsse and
emhane
as code owners
| /// OP Stack full block. | ||
| /// | ||
| /// Withdrawals can be optionally included at the end of the RLP encoded message. | ||
| /// | ||
| /// Taken from [reth-primitives](https://github.com/paradigmxyz/reth) | ||
| #[derive(Debug, Clone, PartialEq, Eq, Default, RlpEncodable, RlpDecodable)] | ||
| #[rlp(trailing)] | ||
| pub struct OpBlock { | ||
| /// Block header. | ||
| pub header: Header, | ||
| /// Transactions in this block. | ||
| pub body: Vec<OpTxEnvelope>, | ||
| /// Ommers/uncles header. | ||
| pub ommers: Vec<Header>, | ||
| /// Block withdrawals. | ||
| pub withdrawals: Option<Vec<Withdrawal>>, | ||
| } |
There was a problem hiding this comment.
We want to use https://github.com/alloy-rs/alloy/blob/main/crates/rpc-types-eth/src/block.rs#L20 instead of duplicating the block definition here. We can then alias Block<OpTxEnvelope> as OpBlock. The issue right now is alloy-rpc-types-eth doesn't support no_std and requires serde by default. I have a pr open for this here: alloy-rs/alloy#1252
There was a problem hiding this comment.
We want to use https://github.com/alloy-rs/alloy/blob/main/crates/rpc-types-eth/src/block.rs#L20 instead of duplicating the block definition here. We can then alias
Block<OpTxEnvelope>asOpBlock. The issue right now isalloy-rpc-types-ethdoesn't supportno_stdand requires serde by default. I have a pr open for this here: alloy-rs/alloy#1252
thank you for your fast reply, i'll wait your pr get merged to use Block type then!
| /// The execution payload. | ||
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
| #[derive(Debug, Default, Clone, PartialEq, Eq)] | ||
| pub struct L2ExecutionPayload { |
There was a problem hiding this comment.
We should be able to avoid duplicating this type and use an alloy execution payload type as well.
There was a problem hiding this comment.
Here's the ExecutionPayload type: https://github.com/alloy-rs/alloy/blob/4492c25f1a666881d18367dc47d0040fc05b17ae/crates/rpc-types-engine/src/payload.rs#L594
There was a problem hiding this comment.
I also have a pr open in upstream alloy to support no_std in alloy-rpc-types-engine: alloy-rs/alloy#1233
There was a problem hiding this comment.
Thanks for sharing this,
Should we wait for your changes to get merged upstream before we integrate this into the crate?
There was a problem hiding this comment.
I'm preferable to integrating this the right way with alloy types. It will prevent a lot of duplicate type confusion over the long run. Let's keep this open for now if you don't mind.
|
This payload now exists in https://github.com/alloy-rs/op-alloy/blob/main/crates/rpc-types-engine/src/payload_v3.rs |
Since we dont use anyhow anymore we made new type for error handling