feat: replacing the map types (#1365) #1368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replacing the HashMap and HashSet from the std::collections to the alloy-primitives along with setting up the cargo file. - setting the dependencies in the cargo files
dhruvmalik007
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
mattsse
requested changes
Sep 26, 2024
| @@ -30,6 +30,7 @@ alloy-rpc-types-mev = { workspace = true, optional = true } | |||
| alloy-rpc-types-trace = { workspace = true, optional = true } | |||
| alloy-rpc-types-txpool = { workspace = true, optional = true } | |||
| serde = { workspace = true, features = ["derive", "std"] } | |||
| alloy-primitives = { version = "0.8.5", features = ["map"] } | |||
Comment on lines
+30
to
+32
| let mut module_map: HashMap<String, String> = HashMap::default(); // Change to FxHashMap | ||
|
|
||
| module_map.extend([ |
|
Hey, unfortunately needed to take over this PR to get this over the line ASAP. I've added you as a co-author in #1384, sorry about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacing the HashMap and HashSet from the std::collections to the alloy-primitives along with setting up the cargo file.
setting the dependencies in the cargo files
[ ]Bug fixes and new features should include tests: TBD.
Motivation
to close the PR #1365 .
Solution
migrating the types as defined in the given issue.
PR Checklist