feat: basic drm support #54
Conversation
src/helpers/drm.ts
Outdated
| let spc_string = btoa(String.fromCharCode(...new Uint8Array(event.message))); | ||
| let licenseResponse = await fetch(licenseServerUrl, { | ||
| method: 'POST', | ||
| headers: new Headers({'Content-type': 'application/json', 'X-AxDRM-Message': 'eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ2ZXJzaW9uIjoxLCJjb21fa2V5X2lkIjoiNjllNTQwODgtZTllMC00NTMwLThjMWEtMWViNmRjZDBkMTRlIiwibWVzc2FnZSI6eyJ2ZXJzaW9uIjoyLCJ0eXBlIjoiZW50aXRsZW1lbnRfbWVzc2FnZSIsImxpY2Vuc2UiOnsiYWxsb3dfcGVyc2lzdGVuY2UiOnRydWV9LCJjb250ZW50X2tleXNfc291cmNlIjp7ImlubGluZSI6W3siaWQiOiIyMTFhYzFkYy1jOGEyLTQ1NzUtYmFmNy1mYTRiYTU2YzM4YWMiLCJ1c2FnZV9wb2xpY3kiOiJUaGVPbmVQb2xpY3kifV19LCJjb250ZW50X2tleV91c2FnZV9wb2xpY2llcyI6W3sibmFtZSI6IlRoZU9uZVBvbGljeSIsInBsYXlyZWFkeSI6eyJwbGF5X2VuYWJsZXJzIjpbIjc4NjYyN0Q4LUMyQTYtNDRCRS04Rjg4LTA4QUUyNTVCMDFBNyJdfX1dfX0.D9FM9sbTFxBmcCOC8yMHrEtTwm0zy6ejZUCrlJbHz_U'}), |
There was a problem hiding this comment.
That's a test token for public test stream, so no need to scrub it
|
🎉 This issue has been resolved in version 1.2.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This issue has been resolved in version 1.2.0-next.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@uhodimOgorodami basically, this is a part of https://github.com/Uscreen-video/uscreen_2/pull/15714. So once we are fine with those changes, this request could also be approved. Thanks 🙏 |
@timaramazanov how we releasing new player versions in general? |
|
@savroff by pushing commits into the main branch, GH actions will build new version and publish it in NPM, we will need to update player version in uscreen repo after |
|
@savroff and to create new |
| @@ -0,0 +1,57 @@ | |||
| import { DRMSystemConfiguration } from "../types"; | |||
|
|
|||
| export const initFairPlayDRM = async (element: HTMLElement, fairPlayOptions: DRMSystemConfiguration) => { | |||
There was a problem hiding this comment.
we can be more precise here and say that we expect HTMLVideoElement, mb rename var element to videoElement ?
| drmSystems: this.drmOptions | ||
| ? { | ||
| "com.apple.fps": { | ||
| licenseUrl: this.drmOptions[KeySystems.fps].licenseUrl, |
There was a problem hiding this comment.
DRMOptions type declares that all keys are optional, should we double check here if all option that we are going to use are actually exists ? Or if we suppose that client should pass all keys to options - maybe we should reflect it in the type ?
| videoCapabilities: [{ contentType: 'application/vnd.apple.mpegurl' }], | ||
| }]); | ||
|
|
||
| console.log(access); |
There was a problem hiding this comment.
do we need this log?
If so - let's use debug lib, here an example: https://github.com/Uscreen-video/video-player/blob/main/src/components/video-container/subtitles.ts#L7
Short description
Basic DRM support
Technical description
This PR adds basic DRM support to video-player.
There are two ways to implement DRM:
This should be enough for now, as hls is supported natively on Apple / Safari only. All others are using hls.js fallback. No additional formats are supported now
Basic DRM playback documentation could be find here