Fix compilation on MacOS #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ause issues with the pointer down the line. Since there's no ctx lifetime on the section, this should be fine.
TheDan64
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simply fixes the conditional compilation code inside values/mod.rs to correctly use the &str type instead of String
Related Issue
#497
How This Has Been Tested
Code was built on a MacOS x86_64 and MacOS Aarch64 machine (13.0 and 13.4) using github actions
On a side note, it may be wise to setup actions to automatically build the project to prevent issues like this.
There hasn't been any testing of the specific section function, but any issues after this change will have existed beforehand, all this change does it fix the compiler error.
Checklist