Adding get_allocated_type, is_terminator and is_conditional to InstructionValue #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDan64
reviewed
Dec 23, 2023
src/values/instruction_value.rs
Outdated
| @@ -282,6 +298,15 @@ impl<'ctx> InstructionValue<'ctx> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| // SubTypes: Only apply to alloca instruction | |||
| /// Returns the type that is allocated by the alloca instruction. | |||
| pub fn get_allocated_type(self) -> Result<AnyTypeEnum<'ctx>, &'static str> { | |||
There was a problem hiding this comment.
Wouldn't this only be a BasicTypeEnum? I would imagine AnyType has types that cannot be allocated?
There was a problem hiding this comment.
Oh yeah that's correct! I incorrectly assumed it would be the same return type as get_type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the 3 Functions and the corresponding tests.
Description
Related Issue
#454
How This Has Been Tested
Only tested on LLVM-16
Checklist