Support LLVM 17 #448
Closed
Support LLVM 17 #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the following LLVM-C API changes:
* Core
* Removed functions:
* LLVMContextSetOpaquePointers
* LLVMConstSelect
* Transforms
* PassRegistry and pass initialization removed, as they were
the part of legacy Pass Manager. This results in complete
removal of the following modules:
* instcombine
* ipo
* pass_manager_builder
* scalar
* util
* vectorize
* Debug info
* New language:
* Mojo
Fixes: TheDan64#444
|
Update the README 🙏 ? |
|
Any updates on this? |
|
@vadorovsky We can merge this once the test suite is fixed to work with other versions |
|
Is anything needed other than to add entries for 17-0 to test.yml to enable CI? I can help out if needed. |
Merged
|
I put out a PR that gets us over the edge. Was just an import typo: #460 |
|
Ah shoot, spoke too soon. All the tests and examples are broken on llvm 17. |
|
Whoops, sorry for lack of reaction! I will try to fix the tests later today. I will also add README changes. |
|
That'd be great! You can grab my commit here: Looks like some From conversions are broken: https://github.com/SUPERCILEX/inkwell/actions/runs/7471632843/job/20332249713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #444
Description
Add
llvm17-0feature with LLVM 17 support.This includes the following LLVM-C API changes:
Related Issue
#444
How This Has Been Tested
No additional tests apart from the existing ones.
Option<Breaking Changes>
PassManagerBuilderfor LLVM 17, as it was removedPassManagermethods, as the corresponding functions were removed.Checklist