Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search text and title when route changes #3701

Conversation

guemax
Copy link
Contributor

@guemax guemax commented Jul 12, 2024

Previously, only the h1 below the search field updated when going back and forth in the browsing history. With this change, the title displayed in the tab and the text in the search field update as well, see the attached screen cast.

screencast.mp4

Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Bnyro Bnyro merged commit 3c177a0 into TeamPiped:master Jul 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants