Add support for HEIF based images #2633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto heic-support
| @@ -35,51 +68,71 @@ public static void TransformSse(ref Vector128<int> input, ref Vector128<int> out | |||
| Vector128<int> v0, v1, v2, v3; | |||
|
|
|||
| int endidx = 3 * columnNumber; | |||
| s0 = Sse41.Add(input, Unsafe.Add(ref input, endidx)); | |||
| s3 = Sse41.Subtract(input, Unsafe.Add(ref input, endidx)); | |||
| s0 = Sse2.Add(input, Unsafe.Add(ref input, endidx)); | |||
There was a problem hiding this comment.
If possible, we should look to use Vector128 opreators and methods here that should abstract the instrinsic support.
I'm a little nervous also about the lack of contraints here. Are they strictly defined in the caller?
| output1 = step2; | ||
| output2 = step1; | ||
| output3 = step3; | ||
| } | ||
|
|
||
| public void TransformAvx2(ref Vector256<int> input, ref Vector256<int> output, int cosBit, int columnNumber) |
There was a problem hiding this comment.
I would try to normalize these. Having specific public Avx2/SSe methods is something we want to remove from the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR is an attempt to start with #1320
Implemented decoding and encoding of images based on a HEIF (ISO/IEC 23008-12:2022) container. These include (amongst others): HEIC, HIF and AVIF.
Please note this PR does NOT add any new compression algorithm to ImageSharp. For now it will take a JPEG thumbnail as its pixel source.
Needless to say, much more work is needed after this PR to reach the goal. I'm try to help there also.
Please do let me know any comments, also on whether to support the HEIF file format in the first place.