Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add discount details block #1920

Open
wants to merge 4 commits into
base: unstable
Choose a base branch
from
Open

feat: add discount details block #1920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86fea47
feat: add discount details block
devisscher May 1, 2024
7f8adc0
rm package.json
iphipps Sep 10, 2024
06b979a
re add package.json and remove the lock
iphipps Sep 10, 2024
92e3ac7
Rename to function settings
devisscher Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .../surfaces/admin/screenshots/admin.discount-details.function-settings-render.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions packages/ui-extensions/docs/surfaces/admin/staticPages/targets-overview.doc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,12 @@ You register targets in your \`shopify.extension.toml\` and inside the Javascrip
'This page shows information about a single gift card. The `admin.gift-card-details.block.render` target is available on this page.',
image: 'admin.gift-card-details.block.render.png',
},
{
title: 'Discount details function settings',
image: 'admin.discount-details.function-settings-render.png',
description:
'This page shows information about a single discount. The `admin.discount-details.function-settings.render` target is available on this page.',
},
{
title: 'Order details',
description:
Expand Down
10 changes: 10 additions & 0 deletions packages/ui-extensions/src/surfaces/admin/extension-targets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,16 @@ export interface ExtensionTargets {
AllComponents
>;

/**
* Renders an admin block in the discount details page.
*
* See the [list of available components](/docs/api/admin-extensions/components).
*/
'admin.discount-details.function-settings.render': RenderExtension<
BlockExtensionApi<'admin.discount-details.function-settings.render'>,
AllComponents
>;

/**
* Renders an admin block in the customer details page.
*
Expand Down
Loading