Implement Prism -> Sorbet translation for it keyword
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
commented
Sep 3, 2024
parser/prism/Parser.h
Outdated
| pm_options_free(options); | ||
| delete options; | ||
| })*/ { | ||
| // `pm_parser_init()` does an immutable borrow of `options`. |
There was a problem hiding this comment.
The expected memory management pattern is:
pm_options_t options = {};
pm_string_t input = {};
pm_parser_t parser;
pm_parser_init(&parser, pm_string_source(&input), pm_string_length(&input), &options);
pm_node_t *node = pm_parse(&parser);
// do whatever
pm_node_destroy(&parser, node);
pm_parser_free(&parser);
pm_string_free(&input);
pm_options_free(&options);In general a good place to look for this is extension.c (https://github.com/ruby/prism/blob/main/ext/prism/extension.c) in the Prism repo which effectively is a consumer of the C API of Prism for use in CRuby.
TODO: update this in the Prism C API docs.
14 tasks
amomchilov
force-pushed
the
Alex/translate-simple-keywords
branch
from
db7a7b3
to
476b1e3
Compare
amomchilov
force-pushed
the
Alex/translate-keyword-it
branch
from
55a38cc
to
4282cc6
Compare
amomchilov
force-pushed
the
Alex/translate-keyword-it
branch
from
4282cc6
to
0c3d1f1
Compare
amomchilov
force-pushed
the
Alex/translate-keyword-it
branch
from
0c3d1f1
to
082c0c9
Compare
egiurleo
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #122.
Closes #229.
Test plan
See included automated tests.