Add map helper
#193
Draft
Add map helper
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of listing all the `srcs` and `hdrs` for the Prism C library, use a glob to pull all `.c` and `.h` files, excluding the ones that are generated by the genrule so that we can specify that the library depends on that genrule without listing those files twice.
…et or prism If `--parser=prism`, diverge in the `pipeline.cc` file and run a separate method that parses the source with prism.
This involves setting up a `convertPrismToSorbet` method that checks against every possible node type. Program and Statements are basically skipped because Sorbet doesn't use them, and then Integer is converted from a prism node to a Sorbet node. Co-authored-by: Vinicius Stock <[email protected]>
1. Add a new test suite that only tests files in the `test/prism_regression` folder 2. Modify Sorbet's test code to allow the user to specify a parser 3. Add logic to the pipeline test runner to call `runPrismParser` when specified
Sorbet constructs slightly different ASTs depending on whether a program contains one statement or more than one statements. Correctly parsing programs with more than one statement will make it easier to benchmark this project.
In order to compare the performance of Prism with the Sorbet parser, we need to be able to stop AST generation after Prism has run and before we translate the Prism AST into the Sorbet AST.
These benchmarks will help us measure the progress of the prism in Sorbet project. While they can be run from any machine, for "official" results, they should be run on an AWS bare metal instance. Results should be added to the prism_benchmarks/data directory.
Relocate it to the `PM_STATEMENTS_NODE` case so it can be reused by multiple parent nodes.
Use a string literal as the default fallback
Implement Prism -> Sorbet translation for `Hash` literals
Implement Prism -> Sorbet translation for method calls
Tidy up our null checks
egiurleo
approved these changes
Aug 16, 2024
| @@ -7,6 +7,8 @@ using std::unique_ptr; | |||
|
|
|||
| namespace sorbet::parser::Prism { | |||
|
|
|||
| namespace { | |||
There was a problem hiding this comment.
C++ newb question -- what does this empty namespace do here?
There was a problem hiding this comment.
Great question. I'll let you know when I find out.
I just saw that unexported functions were put into anonymous namespaces like this in other files, so I cargo-culted it. :')
There was a problem hiding this comment.
These are "anonymous" namespaces. To a first approximation, anonymous namespaces are the equivalent of static: the enclosed names aren't exposed from the compilation unit (i.e. the .cc file).
|
Actually gonna take this back to draft, I have a few ideas to make it simpler, but it's lower priority so I'll come back to it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ideally, I'd like to use
std::views::transformto mimic Ruby'sArray#mapto simplify this "take some things, transform them, and collect the results" pattern, but it's not available until C++20/23.We can use C++17's
std::transform, but it's so over-parameterized that it's actually uglier than just writing theforloop yourself (and by an impressive margin!).This PR is the next best thing, channelling some other-worldly-looking generics to create these
mapIntoandmapIntoNodeVechelpers.Test plan
All existing tests pass.