Account for RBS untyped functions #2631
Merged
+542
−5,192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
andyw8
approved these changes
Sep 30, 2024
|
FYI @soutaro |
vinistock
force-pushed
the
vs-account-for-rbs-untyped-functions
branch
from
7fc52b8
to
eefdc2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2630
According to ruby/rbs#1806, it seems that this new
UntypedFunctiontype represents methods that accept any arguments, but still define some explicit return type.If my understanding is correct, then it makes sense that the class doesn't implement
required_positionals. It accepts anything, there are no parameters to list.Implementation
Started handling the new class when processing parameters. Note that we need to check for the class' existence to prevent breaking in older RBS versions.
Since we don't index return types, for our purposes an
UntypedFunctionis just a method that accepts a forward parameter. This is not 100% equivalent, but since we don't have the concept of "accept anything", it's the closest way to represent it.Automated Tests
Added a test that breaks without the fix.