[skeleton] Make cart banner optimistic #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottdixon
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Thanks for another contribution @frontsideair! Subtle but important piece of the UX 🙌 Left a few comments.
|
Thanks for the review! I made the changes, except my note about |
|
@scottdixon can I ping you on this, if you have the bandwidth? Also for #2503 and #2506 |
scottdixon
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Thanks again @frontsideair!
Left a couple of comments and ccing @wizardlyhel for a second set of eyes 🙏
|
@scottdixon thanks for the review, sent a fix just now. |
wizardlyhel
approved these changes
Sep 27, 2024
scottdixon
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
While the cart sidebar is optimistic, the banner isn't, which is inconsistent
WHAT is this pull request doing?
It makes the cart banner count optimistic
HOW to test your changes?
Post-merge steps
Checklist