Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H2O compatibility date #2380

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

H2O compatibility date #2380

wants to merge 4 commits into from

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jul 29, 2024

Let Hydrogen specify a compatibility date for Oxygen workers:

  • In dev, it passes the compat date to MiniOxygen.
  • It generates oxygen.json file at build time, which will be uploaded to Oxygen.

The date, for now, comes from Hydrogen version (calver): 2024.7.5 (the last number is the patch release, not a day) becomes 2024-07-01, always using the first day of the month. This will change to 2024-10-01 when we release the new major in October.

The format of oxygen.json is: {"version": 1, "compatibilityDate": "2024-07-01"}

@frandiox frandiox added the Blocked Progress on this issue is blocked by something outside of our control label Jul 29, 2024
Copy link
Contributor

shopify bot commented Jul 29, 2024

Oxygen deployed a preview of your fd-h2o-compat branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment July 31, 202411:00 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 31, 202411:00 AM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 31, 202411:01 AM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 31, 202411:00 AM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 31, 202411:00 AM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 31, 202411:00 AM

Learn more about Hydrogen's GitHub integration.

@frandiox frandiox marked this pull request as ready for review September 30, 2024 06:02
@frandiox frandiox requested a review from a team September 30, 2024 06:02
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

@frandiox
Copy link
Contributor Author

This is ready for review, although not for merging yet. Let's wait until Oxygen supports this (hopefully for our 2024-10 major release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Progress on this issue is blocked by something outside of our control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant