[HACKDAYS] O2 cache #2283
Draft
[HACKDAYS] O2 cache #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
frandiox
commented
Jul 29, 2024
| return { | ||
| if (pluginOptions?.unstableOxygenCache) { | ||
| code = | ||
| `import '@shopify/mini-oxygen/unstable-cache-polyfill';` + code; |
There was a problem hiding this comment.
TODO: use magic-string
frandiox
added
the
Blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC of a possible Oxygen cache using HTTP calls. This PR implements the cache strategy locally in MiniOxygen and supports the same approach in a production build with a polyfill to avoid changes in user code (i.e.
await caches.open(...)works in the same way as the original version).However, this can't be merged until the same approach is supported in Oxygen production itself.