Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgrest: install required DLLs #6212

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Conversation

develop7
Copy link
Contributor

@develop7 develop7 commented Sep 24, 2024

Downloads DLLs postgrest.exe is linked against making postgrest work out of the box

Closes #5959 (see screenshot below)

VirtualBox_win10test_27_09_2024_16_16_23

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

postgrest

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@develop7 develop7 marked this pull request as ready for review September 24, 2024 15:10
@HUMORCE
Copy link
Member

HUMORCE commented Sep 26, 2024

Create a separate manifest for psqlodbc instead.

@develop7
Copy link
Contributor Author

Create a separate manifest for psqlodbc instead.

@HUMORCE how should it look like to have #5959 go away? could you suggest some key points, or, better yet, give an example of a similar manifest?

@HUMORCE
Copy link
Member

HUMORCE commented Sep 26, 2024

I mean creates psqlodbc as separate manifest as dependency for similar situation like this manifest.

@HUMORCE
Copy link
Member

HUMORCE commented Sep 26, 2024

I created that: 081d217

@develop7
Copy link
Contributor Author

develop7 commented Sep 27, 2024

I created that: 081d217

@HUMORCE thank you for going forward with the psqlodbc manifest, but depending on the it doesn't help — postgrest.exe doesn't start quoting the lack of LIBPQ.DLL (see the screenshot below)
VirtualBox_win10test_27_09_2024_16_09_58

@develop7
Copy link
Contributor Author

UPD: Added the screenshot with the #5959 fixed

@HUMORCE
Copy link
Member

HUMORCE commented Sep 27, 2024

I forgot to add it to the PATH, fixed: 7bb9cff

Please test it again.

❯ scoop install psqlodbc postgrest
Installing 'psqlodbc' (17.00.0000) [64bit] from 'main' bucket
Loading psqlodbc_x64.msi from cache
Checking hash of psqlodbc_x64.msi ... ok.
Extracting psqlodbc_x64.msi ... done.
Linking ~\scoop\apps\psqlodbc\current => ~\scoop\apps\psqlodbc\17.00.0000
Adding ~\scoop\apps\psqlodbc\current\bin to your path.
'psqlodbc' (17.00.0000) was installed successfully!
Installing 'postgrest' (12.2.3) [64bit] from 'main' bucket
Loading postgrest-v12.2.3-windows-x64.zip from cache
Checking hash of postgrest-v12.2.3-windows-x64.zip ... ok.
Extracting postgrest-v12.2.3-windows-x64.zip ... done.
Linking ~\scoop\apps\postgrest\current => ~\scoop\apps\postgrest\12.2.3
Creating shim for 'postgrest'.
'postgrest' (12.2.3) was installed successfully!
'postgrest' suggests installing 'postgresql'.
~
❯ postgrest
27/Sep/2024:18:38:35 +0000: Starting PostgREST 12.2.3 (519615d)...
27/Sep/2024:18:38:35 +0000: Listening on port 3000
...

@develop7
Copy link
Contributor Author

develop7 commented Oct 1, 2024

@HUMORCE works for me too, thank you!

@HUMORCE HUMORCE merged commit 6be6953 into ScoopInstaller:master Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: postgrest fails to start because of missing DLLs required
2 participants