[email protected]: Add required registry keys #11499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/verify |
|
All changes look good. Wait for review from human collaborators. firefoxpwa
|
HUMORCE
approved these changes
Jun 24, 2023
filips123
force-pushed
the
add-firefoxpwa-registry
branch
from
d6d741b
to
7a87e84
Compare
filips123
changed the title
|
I've fixed conflicts that were caused by the new version and also added suggestions for vcredist and Firefox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PWAsForFirefox needs some registry keys to function correctly. This PR adds those keys in
post_installand removes them inpost_uninstall. More details are here.Additionally, I've changed the description and added notes to be consistent with other PWAsForFirefox packages.
There is still one remaining issue PWAsForFirefox won't be able to locate 7-Zip installed via Scoop. This will be fixed in the next PWAsForFirefox version. More details are here.
Closes #11321