Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-notification-list-group): group header hight is shorter when collapsed #9953

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

fix(ui5-notification-list-group): group header hight is shorter when collapsed #9953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/fiori/src/themes/NotificationListGroupItem.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@
cursor: pointer;
}

.ui5-nli-group-header[aria-expanded="false"] {
height: 2.75rem;
}

/* The focus is on the whole group but should be visualized on the Group Header */
:host([desktop]) .ui5-nli-focusable.ui5-nli-group-root:focus .ui5-nli-group-header::before,
.ui5-nli-focusable.ui5-nli-group-root:focus-visible .ui5-nli-group-header::before {
Expand All @@ -54,6 +58,12 @@
pointer-events: none;
}

:host([desktop]) .ui5-nli-focusable.ui5-nli-group-root:focus .ui5-nli-group-header[aria-expanded="false"]::before,
.ui5-nli-focusable.ui5-nli-group-root:focus-visible .ui5-nli-group-header[aria-expanded="false"]::before {
top: var(--_ui5-notification_group_header-margin_collapsed);
bottom: var(--_ui5-notification_group_header-margin_collapsed);
}

.ui5-nli-group-toggle-icon {
min-width: 1rem;
min-height: 1rem;
Expand Down
1 change: 1 addition & 0 deletions packages/fiori/src/themes/base/NotificationListItem-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
--_ui5-notification_item-border-radius: 0px;
--_ui5-notification_group_header-border-bottom-width: 0.0625rem;
--_ui5-notification_group_header-margin: 0px;
--_ui5-notification_group_header-margin_collapsed: 0.05rem;
--_ui5-notification_group_header-padding: 1rem 0.5rem;
--_ui5-notification_item-state-icon-padding: 0.625rem;
--_ui5-notification_item-border-bottom: var(--ui5-listitem-border-bottom);
Expand Down