Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] added podLabels and podAnnotations at chart and component level #87

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[FEAT] added podLabels and podAnnotations at chart and component level #87

merged 1 commit into from
Sep 30, 2024

Conversation

skrishnan-sap
Copy link
Contributor

CHANGES:

  • added template function to merge and print maps
  • adeed .Values.podLabels and .Values.podAnnotations at top level
  • added .Values.<component>.podLabels and .Values.<component>.podAnnotations at component level
  • deployments adjusted with new values

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

skrishnan-sap added a commit to SAP/cap-operator that referenced this pull request Sep 30, 2024
@skrishnan-sap
[WEBSITE] add helm values from SAP/cap-operator-lifecycle#87
edac9fe
anirudhprasad-sap
anirudhprasad-sap approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@anirudhprasad-sap anirudhprasad-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Pavan-SAP
Pavan-SAP approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Pavan-SAP Pavan-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@skrishnan-sap skrishnan-sap merged commit 8b9e336 into main Sep 30, 2024
7 checks passed
@skrishnan-sap skrishnan-sap deleted the chart-pod-labels branch September 30, 2024 16:18
skrishnan-sap added a commit to SAP/cap-operator that referenced this pull request Sep 30, 2024
@skrishnan-sap
[WEBSITE] add helm values from SAP/cap-operator-lifecycle#87
4a43bc6
skrishnan-sap added a commit to SAP/cap-operator that referenced this pull request Sep 30, 2024
@skrishnan-sap
[WEBSITE] add helm values from SAP/cap-operator-lifecycle#87 (#142)
7162de2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pavan-SAP Pavan-SAP Pavan-SAP approved these changes

@anirudhprasad-sap anirudhprasad-sap anirudhprasad-sap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skrishnan-sap @Pavan-SAP @anirudhprasad-sap