Add plotjuggler to windows #407

gftabor · 2023-09-26T21:14:35Z

No description provided.

mostly I just want to see if windows segfaults again

gftabor · 2023-09-27T20:20:06Z

Hmmmm segfault for windows. I hoped trying a second time would magically solve it, it did not.

Tobias-Fischer · 2023-09-30T14:05:06Z

@gftabor - do you have a Windows machine and could try a local build?

gftabor · 2023-09-30T20:55:03Z

error.txt

Tobias-Fischer · 2023-11-10T01:11:43Z

It looks like this could be relevant - could you please try?

https://github.com/protocolbuffers/protobuf/blob/main/cmake/README.md#dlls-vs-static-linking

Alternatively, we could just patch out the Protobuf parser in Plotjuggler.

traversaro · 2023-11-10T08:15:16Z

error.txt

The error seems:

[508/509] Linking CXX shared library devel\bin\ProtobufParser.dll
FAILED: devel/bin/ProtobufParser.dll devel/lib/ProtobufParser.lib 
cmd.exe /C "cmd.exe /C "%BUILD_PREFIX%\Library\bin\cmake.exe -E __create_def %SRC_DIR%\build\plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\.\exports.def %SRC_DIR%\build\plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\.\exports.def.objs && cd %SRC_DIR%\build" && %BUILD_PREFIX%\Library\bin\cmake.exe -E vs_link_dll --intdir=plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~3\2019\COMMUN~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe /nologo plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\ProtobufParser_autogen\mocs_compilation.cpp.obj plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\error_collectors.cpp.obj plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\protobuf_parser.cpp.obj plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\protobuf_factory.cpp.obj  /out:devel\bin\ProtobufParser.dll /implib:devel\lib\ProtobufParser.lib /pdb:devel\bin\ProtobufParser.pdb /dll /version:0.0 /machine:x64 /INCREMENTAL:NO  /DEF:plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\.\exports.def  C:\Users\tabor\anaconda3\Library\lib\libprotobuf.lib  devel\lib\plotjuggler_base.lib  devel\lib\plotjuggler_qwt.lib  %PREFIX%\Library\lib\Qt5Xml_conda.lib  %PREFIX%\Library\lib\Qt5PrintSupport_conda.lib  %PREFIX%\Library\lib\Qt5Concurrent_conda.lib  %PREFIX%\Library\lib\Qt5Svg_conda.lib  %PREFIX%\Library\lib\Qt5OpenGL_conda.lib  %PREFIX%\Library\lib\Qt5Widgets_conda.lib  %PREFIX%\Library\lib\Qt5Gui_conda.lib  %PREFIX%\Library\lib\Qt5WebSockets_conda.lib  %PREFIX%\Library\lib\Qt5Network_conda.lib  %PREFIX%\Library\lib\Qt5Core_conda.lib  devel\lib\lua_static.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib  && cd ."
LINK: command "C:\PROGRA~2\MICROS~3\2019\COMMUN~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe /nologo plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\ProtobufParser_autogen\mocs_compilation.cpp.obj plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\error_collectors.cpp.obj plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\protobuf_parser.cpp.obj plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\protobuf_factory.cpp.obj /out:devel\bin\ProtobufParser.dll /implib:devel\lib\ProtobufParser.lib /pdb:devel\bin\ProtobufParser.pdb /dll /version:0.0 /machine:x64 /INCREMENTAL:NO /DEF:plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\.\exports.def C:\Users\tabor\anaconda3\Library\lib\libprotobuf.lib devel\lib\plotjuggler_base.lib devel\lib\plotjuggler_qwt.lib %PREFIX%\Library\lib\Qt5Xml_conda.lib %PREFIX%\Library\lib\Qt5PrintSupport_conda.lib %PREFIX%\Library\lib\Qt5Concurrent_conda.lib %PREFIX%\Library\lib\Qt5Svg_conda.lib %PREFIX%\Library\lib\Qt5OpenGL_conda.lib %PREFIX%\Library\lib\Qt5Widgets_conda.lib %PREFIX%\Library\lib\Qt5Gui_conda.lib %PREFIX%\Library\lib\Qt5WebSockets_conda.lib %PREFIX%\Library\lib\Qt5Network_conda.lib %PREFIX%\Library\lib\Qt5Core_conda.lib devel\lib\lua_static.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST:EMBED,ID=2" failed (exit code 1120) with the following output:
   Creating library devel\lib\ProtobufParser.lib and object devel\lib\ProtobufParser.exp
protobuf_parser.cpp.obj : error LNK2019: unresolved external symbol "private: static enum google::protobuf::FieldDescriptor::CppType const * const google::protobuf::FieldDescriptor::kTypeToCppTypeMap" (?kTypeToCppTypeMap@FieldDescriptor@protobuf@google@@0QBW4CppType@123@B) referenced in function "public: __cdecl <lambda_bf367ae0e0412ce84dcc511f79a5c9d2>::operator()(class google::protobuf::Message const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,bool)const " (??R<lambda_bf367ae0e0412ce84dcc511f79a5c9d2>@@QEBA@AEBVMessage@protobuf@google@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@_N@Z)
protobuf_parser.cpp.obj : error LNK2019: unresolved external symbol "const google::protobuf::FileDescriptorProto::`vftable'" (??_7FileDescriptorProto@protobuf@google@@6B@) referenced in function "public: __cdecl google::protobuf::FileDescriptorProto::FileDescriptorProto(void)" (??0FileDescriptorProto@protobuf@google@@QEAA@XZ)
protobuf_factory.cpp.obj : error LNK2019: unresolved external symbol "const google::protobuf::FileDescriptorSet::`vftable'" (??_7FileDescriptorSet@protobuf@google@@6B@) referenced in function "public: __cdecl google::protobuf::FileDescriptorSet::FileDescriptorSet(void)" (??0FileDescriptorSet@protobuf@google@@QEAA@XZ)

devel\bin\ProtobufParser.dll : fatal error LNK1120: 3 unresolved externals

[509/509] Linking CXX executable devel\lib\plotjuggler\plotjuggler.exe

Looking in the link command, it is possible to see that the protobuf version is the one in the base environment (i.e. C:\Users\tabor\anaconda3\Library\lib\libprotobuf.lib instead of the one in the host environment i.e. $PREFIX\Library\lib\libprotobuf.lib). Indeed, it does not seems that there is any libprotobuf installed in the host environment. Perhaps there is some metadata problem?

traversaro · 2023-11-10T08:21:29Z

error.txt

The error seems:

[508/509] Linking CXX shared library devel\bin\ProtobufParser.dll
FAILED: devel/bin/ProtobufParser.dll devel/lib/ProtobufParser.lib 
cmd.exe /C "cmd.exe /C "%BUILD_PREFIX%\Library\bin\cmake.exe -E __create_def %SRC_DIR%\build\plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\.\exports.def %SRC_DIR%\build\plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\.\exports.def.objs && cd %SRC_DIR%\build" && %BUILD_PREFIX%\Library\bin\cmake.exe -E vs_link_dll --intdir=plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~3\2019\COMMUN~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe /nologo plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\ProtobufParser_autogen\mocs_compilation.cpp.obj plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\error_collectors.cpp.obj plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\protobuf_parser.cpp.obj plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\protobuf_factory.cpp.obj  /out:devel\bin\ProtobufParser.dll /implib:devel\lib\ProtobufParser.lib /pdb:devel\bin\ProtobufParser.pdb /dll /version:0.0 /machine:x64 /INCREMENTAL:NO  /DEF:plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\.\exports.def  C:\Users\tabor\anaconda3\Library\lib\libprotobuf.lib  devel\lib\plotjuggler_base.lib  devel\lib\plotjuggler_qwt.lib  %PREFIX%\Library\lib\Qt5Xml_conda.lib  %PREFIX%\Library\lib\Qt5PrintSupport_conda.lib  %PREFIX%\Library\lib\Qt5Concurrent_conda.lib  %PREFIX%\Library\lib\Qt5Svg_conda.lib  %PREFIX%\Library\lib\Qt5OpenGL_conda.lib  %PREFIX%\Library\lib\Qt5Widgets_conda.lib  %PREFIX%\Library\lib\Qt5Gui_conda.lib  %PREFIX%\Library\lib\Qt5WebSockets_conda.lib  %PREFIX%\Library\lib\Qt5Network_conda.lib  %PREFIX%\Library\lib\Qt5Core_conda.lib  devel\lib\lua_static.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib  && cd ."
LINK: command "C:\PROGRA~2\MICROS~3\2019\COMMUN~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe /nologo plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\ProtobufParser_autogen\mocs_compilation.cpp.obj plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\error_collectors.cpp.obj plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\protobuf_parser.cpp.obj plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\protobuf_factory.cpp.obj /out:devel\bin\ProtobufParser.dll /implib:devel\lib\ProtobufParser.lib /pdb:devel\bin\ProtobufParser.pdb /dll /version:0.0 /machine:x64 /INCREMENTAL:NO /DEF:plotjuggler_plugins\ParserProtobuf\CMakeFiles\ProtobufParser.dir\.\exports.def C:\Users\tabor\anaconda3\Library\lib\libprotobuf.lib devel\lib\plotjuggler_base.lib devel\lib\plotjuggler_qwt.lib %PREFIX%\Library\lib\Qt5Xml_conda.lib %PREFIX%\Library\lib\Qt5PrintSupport_conda.lib %PREFIX%\Library\lib\Qt5Concurrent_conda.lib %PREFIX%\Library\lib\Qt5Svg_conda.lib %PREFIX%\Library\lib\Qt5OpenGL_conda.lib %PREFIX%\Library\lib\Qt5Widgets_conda.lib %PREFIX%\Library\lib\Qt5Gui_conda.lib %PREFIX%\Library\lib\Qt5WebSockets_conda.lib %PREFIX%\Library\lib\Qt5Network_conda.lib %PREFIX%\Library\lib\Qt5Core_conda.lib devel\lib\lua_static.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST:EMBED,ID=2" failed (exit code 1120) with the following output:
   Creating library devel\lib\ProtobufParser.lib and object devel\lib\ProtobufParser.exp
protobuf_parser.cpp.obj : error LNK2019: unresolved external symbol "private: static enum google::protobuf::FieldDescriptor::CppType const * const google::protobuf::FieldDescriptor::kTypeToCppTypeMap" (?kTypeToCppTypeMap@FieldDescriptor@protobuf@google@@0QBW4CppType@123@B) referenced in function "public: __cdecl <lambda_bf367ae0e0412ce84dcc511f79a5c9d2>::operator()(class google::protobuf::Message const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,bool)const " (??R<lambda_bf367ae0e0412ce84dcc511f79a5c9d2>@@QEBA@AEBVMessage@protobuf@google@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@_N@Z)
protobuf_parser.cpp.obj : error LNK2019: unresolved external symbol "const google::protobuf::FileDescriptorProto::`vftable'" (??_7FileDescriptorProto@protobuf@google@@6B@) referenced in function "public: __cdecl google::protobuf::FileDescriptorProto::FileDescriptorProto(void)" (??0FileDescriptorProto@protobuf@google@@QEAA@XZ)
protobuf_factory.cpp.obj : error LNK2019: unresolved external symbol "const google::protobuf::FileDescriptorSet::`vftable'" (??_7FileDescriptorSet@protobuf@google@@6B@) referenced in function "public: __cdecl google::protobuf::FileDescriptorSet::FileDescriptorSet(void)" (??0FileDescriptorSet@protobuf@google@@QEAA@XZ)

devel\bin\ProtobufParser.dll : fatal error LNK1120: 3 unresolved externals

[509/509] Linking CXX executable devel\lib\plotjuggler\plotjuggler.exe

Looking in the link command, it is possible to see that the protobuf version is the one in the base environment (i.e. C:\Users\tabor\anaconda3\Library\lib\libprotobuf.lib instead of the one in the host environment i.e. $PREFIX\Library\lib\libprotobuf.lib). Indeed, it does not seems that there is any libprotobuf installed in the host environment. Perhaps there is some metadata problem?

I see, that is an optional dependency that gets enable automatically if it is found (see https://github.com/facontidavide/PlotJuggler/blob/a123c36350b4ef116c7d76a79c16832eec6f9643/plotjuggler_plugins/ParserProtobuf/CMakeLists.txt#L7). Probably we can disable it by passing the CMake option -DCMAKE_DISABLE_FIND_PACKAGE_Protobuf=ON, if that is too tricky to do, probably you can either:

Uninstall libprotobuf from the base environment
Do not activate the base environment when your run the boa build (for example via conda config --set auto_activate_base false)

Tobias-Fischer · 2023-11-10T10:11:00Z

In the patch/dependencies.yaml we can add protobuf as a host dep. I’m on my mobile apologies otherwise I’d do myself.

Tobias-Fischer · 2024-01-28T03:55:39Z

Will revisit once #418 is merged, the patches to protobuf there might fix the issue here.

Tobias-Fischer · 2024-02-16T05:47:39Z

This works fine now :)

gftabor added 2 commits September 26, 2023 15:14

Add plotjuggler to windows

930b43d

add it to linux too, why not

845b914

mostly I just want to see if windows segfaults again

Add protobuf as host dep

ec3d7d6

Tobias-Fischer added 2 commits February 16, 2024 13:18

Merge branch 'main' into plotjuggler-win

2eb399b

Tidy up yaml

8028b64

Tobias-Fischer merged commit 4db39d9 into RoboStack:main Feb 16, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add plotjuggler to windows #407

Add plotjuggler to windows #407

gftabor commented Sep 26, 2023

gftabor commented Sep 27, 2023 •

edited

Loading

Tobias-Fischer commented Sep 30, 2023

gftabor commented Sep 30, 2023

Tobias-Fischer commented Nov 10, 2023

traversaro commented Nov 10, 2023 •

edited

Loading

traversaro commented Nov 10, 2023 •

edited

Loading

Tobias-Fischer commented Nov 10, 2023

Tobias-Fischer commented Jan 28, 2024

Tobias-Fischer commented Feb 16, 2024

Add plotjuggler to windows #407

Add plotjuggler to windows #407

Conversation

gftabor commented Sep 26, 2023

gftabor commented Sep 27, 2023 • edited Loading

Tobias-Fischer commented Sep 30, 2023

gftabor commented Sep 30, 2023

Tobias-Fischer commented Nov 10, 2023

traversaro commented Nov 10, 2023 • edited Loading

traversaro commented Nov 10, 2023 • edited Loading

Tobias-Fischer commented Nov 10, 2023

Tobias-Fischer commented Jan 28, 2024

Tobias-Fischer commented Feb 16, 2024

gftabor commented Sep 27, 2023 •

edited

Loading

traversaro commented Nov 10, 2023 •

edited

Loading

traversaro commented Nov 10, 2023 •

edited

Loading