Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bun): remove deprecated sharp instructions #6839

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

antoinepairet
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

sharp is a native package that requires binaries to run. Before version 0.33.0, sharp relied on a postinstall script to download binaries. This made it incompatible with early versions of bun which did not execute postinstall scripts. In the meantime, sharp relies on optionalDependencies to download the binaries. As of Bun v1.0.16, the top 500 npm packages with lifecycle scripts are allowed by default. There is no more need to add sharp in the trustedDependencies of package.json.

References:

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@antoinepairet antoinepairet requested a review from a team as a code owner August 30, 2024 07:46
Copy link

changeset-bot bot commented Aug 30, 2024

⚠️ No Changeset found

Latest commit: 073b73d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 30, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 073b73d

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @antoinepairet 👏 it looks great to me
I think we should update the second file too

Screenshot_20240830-122250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants