e2e : add an inner op of the kmeans algorithm #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lezcano
approved these changes
Jul 15, 2023
|
|
||
| # np.linalg.norm replacement (2-norm only), https://github.com/pytorch/pytorch/issues/105269 | ||
| def norm(a, axis): | ||
| s = (a.conj() * a).real |
There was a problem hiding this comment.
We don't support complex numbers in inductor, so this could very well be a ** 2
There was a problem hiding this comment.
so pytorch/pytorch#105267 is a wontfix?
There was a problem hiding this comment.
#165 has an example of working around not having complex dtypes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a clustering primitive, essentially a single iteration of the k-means algorithm, from https://realpython.com/numpy-array-programming/#clustering-algorithms
This is of course two lines of numpy :-).
Observations:
np.linalg.normdoes not compile (graph break in compilingnp.linalg.normand other np.linalg functions pytorch/pytorch#105269), so cook up an alternative;np.argmin(...)into an explicit for-loop in C++ (wow);torch.compile-ed code keeps working fine.