-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 migrated balance_of to v2 #547
base: develop
Are you sure you want to change the base?
Conversation
87e20f4
to
553f042
Compare
src/components/alerts/index.tsx
Outdated
@@ -16,7 +17,9 @@ import { useAssetsToWithdraw } from '../../hooks/use-assets-to-withdraw'; | |||
export const Alerts = () => { | |||
const { t } = useTranslation(); | |||
|
|||
useAssetsToWithdraw(); | |||
const { collectionId } = useParams(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure about this one ?
I think collectionId
will be always undefined here, Because component is not under <Routes>...</Routes>
in App.tsx
const jellyCollection: JellyCollection = | ||
await jellyInstance.getJellyCollection(collection); | ||
|
||
const balanceResponse = await jellyCollection.getMyBalance(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can rename getMyBalance
method to getAssetsToWithdraw
. Because getMyBalance
is something reminds me of plugBalance
at 1st glance.
Yeah just think about this. And feel free to proceed if you are ok. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I like that suggestion. I'll change it in JellyJS and come back to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
553f042
to
f0ff6fd
Compare
Why?
Migration of the balanceOf method used to see if there's assets to withdraw migrated to v2.
How?
Contribution checklist?
Demo?
There was a console error saying that balanceOf was not an existing method for the canister. The error is gone now.