Skip to content

Commit

Permalink
feat: remove upgrade check
Browse files Browse the repository at this point in the history
  • Loading branch information
jinpresta committed Sep 4, 2024
1 parent a3bd702 commit 364c572
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
2 changes: 0 additions & 2 deletions config/services/eventbus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,3 @@ services:
public: true
arguments:
- "ps_eventbus"
- "3.0.8"
- true
8 changes: 7 additions & 1 deletion src/Service/ModuleInstaller.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@ class ModuleInstaller {
private $absoluteCompare;
private $moduleManager;

public function __construct(string $moduleName, string $moduleVersion, bool $absoluteCompare) {
/**
* @param string $moduleName
* @param string|null $moduleVersion
* @param bool $absoluteCompare
*/
public function __construct(string $moduleName, string $moduleVersion = null, bool $absoluteCompare = false) {
$this->moduleName = $moduleName;
$this->moduleVersion = $moduleVersion;
$this->absoluteCompare = $absoluteCompare;
Expand Down Expand Up @@ -77,6 +82,7 @@ public function isModuleInstalled() {
* @return boolean
*/
public function isModuleVersionSatisfied() {
if (!$this->moduleVersion) return true;
$module = \Module::getInstanceByName($this->moduleName);
return version_compare(
$module->version,
Expand Down

0 comments on commit 364c572

Please sign in to comment.