Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

サンプルRTC不具合（cpack設定、RTC.xml）修正 #1130

Merged
merged 1 commit into from
Dec 18, 2023
Merged

サンプルRTC不具合（cpack設定、RTC.xml）修正 #1130

merged 1 commit into from
Dec 18, 2023

Conversation

n-kawauchi
Copy link

close #1129

Identify the Bug

Link to #1129

Description of the Change

  • ConsoleIn, ConsoleOut については、一番トップのCMakeLists.txtの1行のみ修正すれば今回の不具合は解消するが、最新のOpenRTP2.0.1版にて再生成した
    • このため、CMakeLists.txt以外にもテンプレートが更新されたことによる差分が生じている
  • MyServiceConsumerについてはRTC.xmlの不要なスラッシュ1か所を削除した

Verification

  • ConsoleIn、ConsoleOutの確認
    • Windows環境でmsiを生成してのインストール動作を確認した
    • Ubuntu環境ではDocker Hubのイメージを使用し、Ubuntu20.04コンテナ環境へインストールして実行動作に問題ないことを確認した
  • MyServiceConsumerはRTC.xmlをRTCBにてインポートできることを確認
  • Did you succeed the build?
  • No warnings for the build?
  • Have you passed the unit tests?

@n-kawauchi n-kawauchi self-assigned this Dec 15, 2023
@n-ando n-ando merged commit 1852b08 into OpenRTM:master Dec 18, 2023
1 of 9 checks passed
@n-kawauchi n-kawauchi deleted the update-sample-rtc branch December 25, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n-ando n-ando n-ando approved these changes

Assignees

@n-kawauchi n-kawauchi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

サンプルRTC不具合（cpack設定、RTC.xml）修正
2 participants
@n-kawauchi @n-ando